update to dev13 #28
update to dev13 #28
Conversation
app-lifelike/src/main/java/com/example/lifelike/composable/loggedin/PhotosOfAlbum.kt
Outdated
Show resolved
Hide resolved
app-lifelike/src/main/java/com/example/lifelike/composable/loggedin/PhotosOfAlbum.kt
Outdated
Show resolved
Hide resolved
app-lifelike/src/main/java/com/example/lifelike/composable/loggedin/PhotosOfAlbum.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| ) | ||
| /*Table layout was removed temporarily until we will make it available again with a refreshed API. (Id88a7) |
There was a problem hiding this comment.
I suggest to remove old API completely, as it will be refreshed anyway
@zsoltk what do you think?
|
No problem 👍. The interactive preview is working in the latest android studio now. So that's pretty cool |
|
@zsoltk Looks good to me, can you take a look? |
|
@luca992 When trying to scroll photos of album in app-lifelike (with new
I won't block the release, as it's the Router that's important, but would be nice to fix it in another ticket. |
|
@zsoltk
The bug fix should be included in one of the next compose releases |
|
Ah, I missed that. Fair enough. |
Updates to dev13, update compile and target sdk to 30.
I know you did not want the samples to reference the router module directly. And it should instead reference an existing release. But after being forced to update gradle, the only way I could get the lifelike module to compile was to update it to dev13. Which meant it needed access to router built with dev13.
Also I couldn't get the nested sample to build using dev09 with the gradle update so I was able to update that one to dev12