Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to TypeScript #204

Open
fatfisz opened this issue Jun 1, 2020 · 4 comments
Open

Rewrite to TypeScript #204

fatfisz opened this issue Jun 1, 2020 · 4 comments
Assignees
Milestone

Comments

@fatfisz
Copy link
Collaborator

fatfisz commented Jun 1, 2020

We should retain all different builds, namely:

  • CJS as the default entrypoint
  • ES (set up TypeScript to output something supported by Node 10)
  • minified UMD (for unpkg.js)

Also package.json should point at the TS declaration file.

Most probably Babel will be removed.

@fatfisz fatfisz added this to the 2.0.0 milestone Jun 1, 2020
@fatfisz fatfisz self-assigned this Jun 1, 2020
@Hexagon
Copy link

Hexagon commented Mar 29, 2023

@fatfisz I'm interested in making this work on deno+bun natively, and notice it's been a while since this repo were updated. Is proper esm + native ts + cleanup + publish to deno.land/x going to happen? Would you accept a PR, or should i fork the project and re-publish?

Ref: #201

@Hexagon
Copy link

Hexagon commented Mar 29, 2023

I've started working on this, forked and published https://github.com/hexagon/proper-tags to npm and deno.land/x/proper_tags

Currently WIP but should be working!

@rassie
Copy link

rassie commented May 24, 2023

@Hexagon since your forked repository does not have issues I'd like to ask here: does the typing for inlineArrayTransformer make sense to you? Typescript does not want to compile because conjunction, separator and serial do not exist on strings and as far as I can see, a string type does not make a lot of sense there.

@Hexagon
Copy link

Hexagon commented Jun 18, 2023

@rassie Issues-section added now, and no, that typing does not make sense. Will have to have a look at that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants