Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Eyedropper in the dynamic styling does not copy the red color channel. #1075

Open
antoKeinanen opened this issue Mar 29, 2023 · 10 comments

Comments

@antoKeinanen
Copy link

Your environment

SYSTEM INFO:
	Obsidian version: v1.1.16
	Installer version: v1.1.16
	Operating system: #1 SMP PREEMPT_DYNAMIC Wed, 22 Mar 2023 22:52:35 +0000 6.2.8-arch1-1
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: Things v2.1.6
	Snippets enabled: 1
	Restricted mode: off
	Plugins installed: 4
	Plugins enabled: 4
		1: Kanban v1.5.2
		2: Advanced Merger v1.0.0
		3: Excalidraw v1.8.21
		4: Self-hosted LiveSync v0.17.34

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Describe the bug

When using the eye dropper tool in the new dynamic styling menu (marked in red circle) the red color channel is not set properly.

image

To Reproduce

Steps to reproduce the behavior:

  1. Open any excalidraw drawing.
  2. Click open the hamburger menu.
  3. Click the circular color button at the top right corner.
  4. Click the eyedropper.
  5. Select any color.
  6. See that the red channel is set to NaN.

Expected behavior

The red channel is set to the red color value and not NaN.

@zsviczian
Copy link
Owner

Very strange, however I cannot reproduce the issue. Also the eyedropper is the standard built in HTML component. I only add <input type="color"/> and take the output of the component. The rest comes from Electron browser (the environment under Obsidian). This does not mean that my code is not causing the issue, but it does mean that I do not yet see how that would happen.

When did you download and install Obsidian? Recently or many years back? Maybe reinstalling Obsidian would update Electron as well.

I see your color is in rgba format. does this happen if you use a HEX color?

@antoKeinanen
Copy link
Author

Hex colors seems to work as intended also the color selection. But not the color picker.

I have reinstalled obsidian within last few months because of the computer reset I did. I can try if the issue replicates on my laptop layer today.

@zsviczian
Copy link
Owner

What happens if you change color format in the eyedropper tool?
image

@antoKeinanen
Copy link
Author

What happens if you change color format in the eyedropper tool? image

This does not work.
image

@antoKeinanen
Copy link
Author

This issue also replicates on my laptop.
kuva

@zsviczian
Copy link
Owner

And this impacts all your drawings or just this one?
Though you only have very few plugins.... Can you try installing only Excalidraw in an empty Vault?
Obsidian settings also has the same eyedropper component (Appearance/Accent color). Can you test if the issue replicates there as well?
image

@antoKeinanen
Copy link
Author

The issue replicates in the obsidian setting so I think this is not the place to report the issue.

@zsviczian
Copy link
Owner

does it also happen with the default obsidian style? i.e. disabling Things v2.1.6 and restarting Obsidian.

@antoKeinanen
Copy link
Author

antoKeinanen commented Mar 30, 2023

It does and the css snippet I have loaded just increases font size of latex.

@Nathan-Yorio
Copy link

I also had the issue with a different plugin
Obsidian markdown formatting assistant NAN issue

I've created a formal issue in the bug reports for Obsidian itself on the forums to track this, as it doesn't seem to be a plugin specific issue.
Obsidian forums issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants