Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Aspect Ratio of an Excalidraw Embedded in Another Excalidraw not updated #1707

Closed
Cabjhegas opened this issue Apr 11, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@Cabjhegas
Copy link

Your environment
SYSTEM INFO:
Obsidian version: v1.5.12
Installer version: v1.5.3
Operating system: Windows 10 Home 10.0.19045
Login status: not logged in
Insider build toggle: off
Live preview: on
Base theme: dark
Community theme: Minimal v7.5.3
Snippets enabled: 0
Restricted mode: off
Plugins installed: 9
Plugins enabled: 7
1: Kanban v1.5.3
2: Calendar v1.5.10
3: Imgur v2.5.2
4: Excalidraw v2.1.3
5: Git v2.24.1
6: Iconize v2.11.9
7: Minimal Theme Settings v7.5.0

Describe the bug
If an Excalidraw X is embedded in another Excalidraw Y, and you subsequently alter Excalidraw X (changing its aspect ratio), it will be displayed distorted in Excalidraw Y.

To Reproduce
Steps to reproduce the behavior:
1. Create an Excalidraw X.
2. Create an Excalidraw Y and embed Excalidraw X into it.
3. Alter Excalidraw X so that its aspect ratio is changed.
4. Verify that it appears distorted in Excalidraw Y.

Expected behavior
The version of Excalidraw X embedded in Excalidraw Y needs to be updated, correcting its aspect ratio if necessary.

Screenshots
image

image

image

image

Additional context
If you use the Excalidraw X exported as SVG, any subsequent changes to it will correctly update its display in Excalidraw Y. However, it would be beneficial for the same to occur if you embed the ExcalidrawX.md.

@zsviczian
Copy link
Owner

I am able to reproduce... This is a regression from 2.1.3 preserving image aspect ratios. Sorry for this. I will fix it in the next release.

@zsviczian zsviczian added the bug Something isn't working label Apr 12, 2024
@Cabjhegas
Copy link
Author

Thanks for the awesome plugin!

@zsviczian
Copy link
Owner

Fixed in 2.1.4. Will release over the WE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants