Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Webpack >=5.0.0 as peer dependency #322

Closed
lg-kialo opened this issue Dec 11, 2020 · 1 comment
Closed

Specify Webpack >=5.0.0 as peer dependency #322

lg-kialo opened this issue Dec 11, 2020 · 1 comment

Comments

@lg-kialo
Copy link

lg-kialo commented Dec 11, 2020

Is your feature request related to a problem? Please describe.
The README says that starting with version 6, the plugin only works with Webpack 5+.
But this is not reflected in the peerDependencies of the package.json so when updating my project's dependency this requirement is ignored.

Describe the solution you'd like
Add a peerDependencies section in the package.json specifying that the plugin works with Webpack 5+.
Like this:

{
    ...
    "peerDependencies": {
        "webpack": ">=5.0.0"
    }
}

Describe alternatives you've considered
The alternative is that developers who use your package need to pay attention to the note in the README about compatibility with Webpack, I guess.

Additional context
No additional context.

@ztoben
Copy link
Owner

ztoben commented Dec 11, 2020

Missed this when doing the original major update to webpack 5, so I've pushed this in version 7.0.0 in case there are backward compatibility issues surfaced by the change. Thanks!

@ztoben ztoben closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants