Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build for Web #29

Closed
Errichamonda opened this issue Jan 13, 2020 · 6 comments
Closed

Unable to build for Web #29

Errichamonda opened this issue Jan 13, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@Errichamonda
Copy link

Hi, first of all, nice work with this repo.
I have a problem where I can't build this for web. I've checked all packages and they are all compatable with Web.

I think the problem is withing LanguageStore and ThemeStore. I've tried to search for the problem but I didn't find any answer so I'm asking here, maybe you know how to fix it.

@zubairehman
Copy link
Owner

Hi @Errichamonda,
Currently this project only supports mobile. However i will add web support in near future.

Could you please share the error you are getting? Would be helpful for me to quickly fix and update the project.

@Errichamonda
Copy link
Author

Errichamonda commented Jan 13, 2020

The first problem is that SystemChrome.setPreferredOrientations blocks everything but it's an easy fix.

context.dart:117 Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at core$.ReactiveContext.new.get isWithinBatch [as isWithinBatch] (context.dart:117)
    at core$.ReactiveContext.new.conditionallyRunInAction (context.dart:209)
    at theme_store.ThemeStore.new.set [_darkMode] (theme_store.g.dart:23)
    at theme_store.g.dart:24
    at core$.ReactiveContext.new.conditionallyRunInAction (context.dart:211)
    at theme_store.ThemeStore.new.set [_darkMode] (theme_store.g.dart:23)
    at theme_store.g.dart:24
    .
    . (Cutted becuase it was 1000 rows long but it's always the same error)
    .
    .
    at core$.ReactiveContext.new.conditionallyRunInAction (context.dart:211)
    at theme_store.ThemeStore.new.set [_darkMode] (theme_store.g.dart:23)
    at theme_store.g.dart:24
    at core$.ReactiveContext.new.conditionallyRunInAction (context.dart:220)
    at theme_store.ThemeStore.new.set [_darkMode] (theme_store.g.dart:23)
    at theme_store.ThemeStore.new.theme_store._ThemeStore.new (theme_store.dart:21)
    at theme_store.ThemeStore.new._ThemeStore__$36ThemeStore$36.new (theme_store.dart:28)
    at new theme_store.ThemeStore.new (theme_store.dart:28)
    at new main.MyApp.new (main.dart:46)
    at app_component$46inject.AppComponent$Injector.__.[_createMyApp] (app_component.inject.dart:45)
    at app_component$46inject.AppComponent$Injector.__.get app [as app] (app_component.inject.dart:63)
    at main.dart:37
    at _RootZone.runUnary (zone.dart:1381)
    at _FutureListener.then.handleValue (future_impl.dart:139)
    at handleValueCallback (future_impl.dart:680)
    at Function._propagateToListeners (future_impl.dart:709)
    at _Future.new.[_completeWithValue] (future_impl.dart:524)
    at async._AsyncCallbackEntry.new.callback (future_impl.dart:554)
    at Object._microtaskLoop (schedule_microtask.dart:43)
    at _startMicrotaskLoop (schedule_microtask.dart:52)
    at async_patch.dart:168

This is the error I'm getting in the console. Terminal output (where I run flutter run -d chrome) is empty

@zubairehman zubairehman added the enhancement New feature or request label Jan 21, 2020
@mcemkilinc
Copy link

Latest version gave a different error:
Your Flutter application is created using an older version of the Android embedding. It's being deprecated in favor of Android embedding v2. Follow the steps on
https://flutter.dev/go/android-project-migration to migrate your project.

zubairehman added a commit that referenced this issue Aug 29, 2020
- added user store
- added splash
- refactored repository
@zubairehman
Copy link
Owner

Hi @ALL,

I have added support for the web. Please check out the web-support branch and let me know if you find any issues. Thanks :)

@mcemkilinc
Copy link

Great,thanks, İ will in a couple of days.

@zubairehman
Copy link
Owner

coo. Please feel free to re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants