Added command line parameter to control SLOT_DISTANCE value #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things to consider: AccountUpdateManager struct potentially might have a lot of instances, and withc current implementation every instance will eat up additional 4 bytes. Alternative would be to create a mutable static, and initialize it once at program startup, while this would introduce unsafe into code, it will remove unnecessary overhead of 4 bytes.
polachok
approved these changes
Oct 5, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to consider:
AccountUpdateManager struct potentially might have a lot of instances,
and withc current implementation every instance will eat up additional 4
bytes.
Alternative would be to create a mutable static, and initialize it once at
program startup, while this would introduce unsafe into code, it will
remove unnecessary overhead of 4 bytes.