Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for batch requests #178

Merged
merged 1 commit into from Oct 22, 2021
Merged

Added support for batch requests #178

merged 1 commit into from Oct 22, 2021

Conversation

bmuddha
Copy link
Collaborator

@bmuddha bmuddha commented Oct 18, 2021

Cacher will try to perform preliminary parsing of the request, and if it
encounters a request containing an array of subqueries, then it will
pass it on to validator, otherwise request handling proceeds normally.

Closes SOL 29

@bmuddha bmuddha requested a review from polachok October 18, 2021 10:24
src/rpc.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@polachok polachok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a metric for batch requests, would be interesting to see how many we actually receive.

Cacher will try to perform preliminary parsing of the request, and if it
encounters a request containing an array of subqueries, then it will
pass it on to validator, otherwise request handling proceeds normally.

Added metrics for batch requests
@bmuddha
Copy link
Collaborator Author

bmuddha commented Oct 21, 2021

Added new metric batch_requests, it's just a normal integer counter

@bmuddha bmuddha merged commit 1093bc2 into bestarch-ae:master Oct 22, 2021
@bmuddha bmuddha deleted the batch-requests branch October 25, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants