Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Negative Extra Line Spacing #171

Closed
Sethur opened this issue Apr 3, 2020 · 9 comments
Closed

Feature Request: Negative Extra Line Spacing #171

Sethur opened this issue Apr 3, 2020 · 9 comments

Comments

@Sethur
Copy link

Sethur commented Apr 3, 2020

Just a quick feature request: Since a setting of Extra Line Spacing=0 (and the necessary adaption to the size of the matching braces) still yields an unnecessary large gap between lines, it would be fantastic to allow for negative values of Extra Line Spacing

@zufuliu
Copy link
Owner

zufuliu commented Apr 3, 2020

what about set Extra Line Spacing to empty? is it still has large gaps between lines?
and which font do you use? Consolas, Segoe UI, or other font?

@zufuliu
Copy link
Owner

zufuliu commented Apr 3, 2020

I seems misunderstood your problem.
I think what cause your problem is that all line in Scintilla have same height, which is the maximum line height calculated from all sty;es.
we have size:+1 in Matching Brace, Matching Brace Error and Whitespace global styles, so setting a font with 11 pt, actually make the line height to the value calculated by the same font at 12 pt.

@zufuliu
Copy link
Owner

zufuliu commented Apr 3, 2020

Negative extra line spacing is added by 8d56a73.

@Sethur
Copy link
Author

Sethur commented Apr 3, 2020

@zufuliu : Just to clear this up: I am aware that the minimum line height is also determined by the size settings of Matching Brace, etc., since those will normally produce larger braces that need to be accounted for. However, even with those settings all set to 0 when using Consolas or Courier New at different sizes (e.g. 10), the gap is unnecessarily large. When using negative extra space, one could further reduce the gap (to the point of the letters starting to overlap).

@Sethur
Copy link
Author

Sethur commented Apr 3, 2020

I see you already did a comment on this. Thanks for the quick action.

@zufuliu
Copy link
Owner

zufuliu commented Apr 3, 2020

Maybe it's even better to change matching braces to indicators (with semi-transparent background color), without increasing font size.

@Sethur
Copy link
Author

Sethur commented Apr 4, 2020

Yes, as default setting, that would be one way to avoid the additional gap.

zufuliu added a commit that referenced this issue Apr 5, 2020
Braces are already in bold style, when they are on same line, it easy to find;
when they are different lines, the active block is already highlighted.

TODO: change matching brace style to indicator with semi-transparent background color.
zufuliu added a commit that referenced this issue Apr 7, 2020
@zufuliu
Copy link
Owner

zufuliu commented Apr 7, 2020

Matching Brace and Matching Brace Error changed to indicators in 4bad717.

zufuliu added a commit that referenced this issue Apr 11, 2020
Fixed by using negative extra line spacing (issue #171),
which need be manually adjusted based on rendering technology and font size.
@zufuliu
Copy link
Owner

zufuliu commented Apr 11, 2020

This feature is completed, no style increasing line height now.

@zufuliu zufuliu closed this as completed Apr 11, 2020
RaiKoHoff pushed a commit to RaiKoHoff/notepad2 that referenced this issue Jul 19, 2021
…liu#179 .

Fixed by using negative extra line spacing (issue zufuliu#171),
which need be manually adjusted based on rendering technology and font size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants