Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

large file makes it slow #79

Closed
bluenlive opened this issue Oct 18, 2018 · 5 comments
Closed

large file makes it slow #79

bluenlive opened this issue Oct 18, 2018 · 5 comments
Labels
🐛bug large file
Milestone
v4.20.08

Comments

@bluenlive
Copy link

First of all, It's not a bug.
BTW, I think this should be fixed. ;)

When we open such a large and weired file, this notepad2 works very slowly.
(I attatched a file)
prxoy_20181011.zip

But, flo's original nor Xhmikosr's notepad2-mod are not so slow.
@zufuliu
Copy link
Owner

zufuliu commented Oct 18, 2018

Indeed, there must be something wrong.

zufuliu added a commit that referenced this issue Oct 22, 2018
@zufuliu
Fix poor performance for long line text (issue #79), introduced by 13…
55719a0 
…ed237 (two years ago).
@zufuliu
Copy link
Owner

zufuliu commented Oct 22, 2018

Fixed by commit 55719a0.

zufuliu added a commit that referenced this issue Oct 24, 2018
@zufuliu
Improve large file support, issue #79.
81e1e86
@zufuliu zufuliu closed this as completed Oct 24, 2018
@bluenlive
Copy link
Author

Thank you, always

@zufuliu
Copy link
Owner

zufuliu commented Aug 9, 2020

There is a regression, it's now about 5x slower than Notepad2-Mod.

@zufuliu zufuliu reopened this Aug 9, 2020
@zufuliu zufuliu added this to the v4.20.08 milestone Aug 11, 2020
zufuliu added a commit that referenced this issue Aug 11, 2020
@zufuliu
Improve loading large file (issue #79) by replacing SciCall_AddText()…
792c34f 
… with SciCall_AppendText()

to avoid moving caret to end of document then moving back to beginning of document.
@zufuliu
Copy link
Owner

zufuliu commented Aug 11, 2020

It's seems not a regression, but rather Direct2D is about 3x slower than GDI on processing long line text.
The performance for large file is improved a lot by commit 792c34f.

@zufuliu zufuliu closed this as completed Aug 11, 2020
RaiKoHoff pushed a commit to RaiKoHoff/notepad2 that referenced this issue Jul 19, 2021
@zufuliu
Improve loading large file (issue zufuliu#79) by replacing SciCall_Ad…
eab2092 
…dText() with SciCall_AppendText()

to avoid moving caret to end of document then moving back to beginning of document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug large file
Projects
None yet
Milestone
v4.20.08
Development

No branches or pull requests
2 participants
@bluenlive @zufuliu