Build failure with PostgreSQL 10.x

[mexicarne]

tsearch_extras 0.3 fails to build with pgsql 10.3 with this error:

gmake[1]: Entering directory '/wrkdirs/usr/ports/databases/tsearch_extras/work/tsearch_extras-0.3'
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -DPIC -I. -I./ -I/usr/local/include/postgresql/server -I/usr/local/include/postgresql/internal  -I/usr/local/include -I/usr/local/include -I/usr/local/include  -c -o tsearch_extras.o tsearch_extras.c
tsearch_extras.c:82:47: error: too few arguments to function call, expected 3, have 2
                                                                                          (Node *) makeString(pstrdup("1"))));
                                                                                                                           ^
/usr/local/include/postgresql/server/nodes/makefuncs.h:83:1: note: 'makeDefElem' declared here
extern DefElem *makeDefElem(char *name, Node *arg, int location);
^
1 error generated.

Looks like definition of makeDefElem() has changed to require additional third location argument.

DefElem *
makeDefElem(char *name, Node *arg, int location)

Can this be fixed conditionally for pgsql10?

[timabbott]

@mexicarne sorry we missed this issue report when you made it!

@sampritipanda we should get this working on postgres 10. I assume we just need to add the appropriate #ifdef lines for the arguments expected by these functions.

[mexicarne]

That's fixed the build for me, thank you!