This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Fixes: #136 Narrow by stream on click #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @kunall17, it looks like you've already signed the Dropbox CLA. Thanks! |
|
This looks good. I think a follow-up thing we'll want to do is ensure the narrowing is done in a way where the message that you touched to initiate the narrow on stays in view (rather than jolting around). See for notes on how this works in the webapp. |
|
lgtm. closing this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zulip/zulip-android/blob/master/app/src/main/java/com/zulip/android/filters/NarrowFilterStream.java#L58 here checks for null and not "" therefore this problem was arising!