New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #136 Narrow by stream on click #139

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kunall17
Collaborator

kunall17 commented Aug 18, 2016

@smarx

This comment has been minimized.

smarx commented Aug 18, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott

This comment has been minimized.

Member

timabbott commented Aug 19, 2016

This looks good. I think a follow-up thing we'll want to do is ensure the narrowing is done in a way where the message that you touched to initiate the narrow on stays in view (rather than jolting around). See for notes on how this works in the webapp.

http://zulip.readthedocs.io/en/latest/pointer.html

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

lgtm. closing this PR!

@niftynei niftynei closed this Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment