Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user more info on error in web auth #609

Closed
gnprice opened this issue Apr 2, 2024 · 0 comments · Fixed by #610
Closed

Show user more info on error in web auth #609

gnprice opened this issue Apr 2, 2024 · 0 comments · Fixed by #610
Assignees
Labels
a-first-hour Issues specific to using the app for the first time a-login
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Apr 2, 2024

This is a followup to:

In the version we merged as #600, if anything goes wrong, the error dialog is always the same generic message. But this flow is inherently a bit finicky — it involves sending the user out to a browser, then receiving a callback by having the browser redirect to a special URL — so it's likely things will sometimes go wrong. And indeed a previous draft had a couple of different things go wrong (#600 (comment)). I debugged those pretty quickly because I was running a debug build connected to my desktop and watching a developer console… but when beta users run into issues, we won't have those advantages. It'll therefore really help us out if the error dialog shows more detail about the error, so that a screenshot from the user can start narrowing down where the problem is.

As a first step, when we get a PlatformException we should display its message field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-first-hour Issues specific to using the app for the first time a-login
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants