Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all valid Zulip emoji #669

Open
gnprice opened this issue May 13, 2024 · 0 comments
Open

Track all valid Zulip emoji #669

gnprice opened this issue May 13, 2024 · 0 comments
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)

Comments

@gnprice
Copy link
Member

gnprice commented May 13, 2024

This is a prerequisite for:

In order to offer the user a UI to choose an emoji from the emoji Zulip knows about, we'll need to know what emoji those are and what Zulip calls them.

Zulip has a particular data model for identifying emoji, which is an underdocumented part of the Zulip API. For an introduction, see reaction_type here:
https://zulip.com/api/add-reaction#parameter-reaction_type
and the two companion fields emoji_code and emoji_name. (The same emoji model is used for reactions as for emoji in messages.)

Then see zulip-mobile's src/emoji/data.js, which tracks this model.

A good implementation of this issue will:

  • Cover all three of Zulip's types of emoji.
  • Support efficiently looking up an emoji by name, or by type and code.
  • Support iterating through the list of all Zulip emoji.
@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels May 13, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: No status
Development

No branches or pull requests

1 participant