Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "All messages" to "Combined feed" in our codebase #676

Closed
gnprice opened this issue May 14, 2024 · 0 comments · Fixed by #688
Closed

Rename "All messages" to "Combined feed" in our codebase #676

gnprice opened this issue May 14, 2024 · 0 comments · Fixed by #688
Labels
a-home The home screens of the app; finding and starting conversations server-9 Things new in Zulip Server 9.0

Comments

@gnprice
Copy link
Member

gnprice commented May 14, 2024

This is a followup to:

That issue was for updating the UI. We should also update all the references to this Zulip feature within our code.

A good search to use for this is:
git grep -iP 'all.?messages'
That will find the phrase "all messages" with any capitalization, and with or without a space (or other character) in between the words. Currently it finds 73 results.

When this issue is complete, that search's results won't necessarily be empty — there may be a few matches that aren't referring to the former "All messages" narrow, now called "Combined feed". But it should be possible to look at each of the remaining results and determine how that's not what it's referring to.

For this issue, the most important part of the work is making a highly reviewable PR. Be sure to review that page of the Zulip docs, and the page on clear and coherent commits.

@gnprice gnprice added a-home The home screens of the app; finding and starting conversations server-9 Things new in Zulip Server 9.0 labels May 14, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 14, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 19, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 19, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 21, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 21, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 23, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 23, 2024
Lalit3716 added a commit to Lalit3716/zulip-flutter that referenced this issue May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-home The home screens of the app; finding and starting conversations server-9 Things new in Zulip Server 9.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant