Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows need updating #2178

Closed
keikoro opened this issue May 24, 2024 · 0 comments · Fixed by #2179
Closed

Workflows need updating #2178

keikoro opened this issue May 24, 2024 · 0 comments · Fixed by #2179
Labels
bug Issues that report (apparent) bugs. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.

Comments

@keikoro
Copy link
Collaborator

keikoro commented May 24, 2024 •
edited
Loading

We use outdated versions of actions in our workflows, like actions/checkout@v3, actions/setup-python@v3. These are based on Node 16, which GitHub has phased out, which is why our tests are failing.

The actions need upgrading to Node 20-based versions. See: actions/checkout, actions/setup-python.

Individual warnings below:

isort
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Black
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Flake8
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@keikoro keikoro added bug Issues that report (apparent) bugs. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. labels May 24, 2024
keikoro added a commit that referenced this issue May 24, 2024
@keikoro
ci(workflows): upgrade actions
1d3ad84 
Upgrade outdated (v3, Node 16) GitHub actions used
in workflows to latest versions, which use Node 20.

Closes: #2178
@keikoro keikoro mentioned this issue May 24, 2024
Merged
keikoro added a commit that referenced this issue May 24, 2024
@keikoro
ci(workflows): upgrade actions
754deb1 
Upgrade outdated (v3, Node 16) GitHub actions used
in workflows to latest versions, which use Node 20.

Closes: #2178
keikoro added a commit to keikoro/moviepy that referenced this issue May 25, 2024
@keikoro
ci(workflows): upgrade actions
6c03f9b 
Upgrade outdated (v3, Node 16) GitHub actions used
in workflows to latest versions, which use Node 20.

Closes: Zulko#2178
keikoro added a commit that referenced this issue May 27, 2024
@keikoro
ci(workflows): upgrade actions
bf21ef2 
Upgrade outdated (v3, Node 16) GitHub actions used
in workflows to latest versions, which use Node 20.

Closes: #2178
keikoro added a commit that referenced this issue May 27, 2024
@keikoro
ci(workflows): upgrade actions
2182b8a 
Upgrade outdated (v3, Node 16) GitHub actions used
in workflows to latest versions, which use Node 20.

Closes: #2178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that report (apparent) bugs. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(workflows): upgrade actions Zulko/moviepy
1 participant
@keikoro