Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List decorator and pygame as dependencies on PyPI #4

Closed
alexflint opened this issue Jan 25, 2014 · 6 comments
Closed

List decorator and pygame as dependencies on PyPI #4

alexflint opened this issue Jan 25, 2014 · 6 comments

Comments

@alexflint
Copy link

When I installed moviepy via "pip install moviepy", it did not automatically install the "decorator" and "pygame" modules, which are also available through pip. I had to install these manually.

@Zulko
Copy link
Owner

Zulko commented Jan 25, 2014

Thanks for the feedback.

I don't want Pygame to be installed because it is heavy and not strictly necessary (it is very useful for previews, yet). But indeed decorator could be installed with pip. Numpy, the second important dependency, could also be auto-installed.

I don't remember how you ask pip for automatic installs (preferentially with no re-install if the package is already installed). Do you happen to know how to do that ?

In the meantime I will update the docs.

@alexflint
Copy link
Author

Cool. Add requires=['numpy', 'decorator'] to setup.py. You can also specify
specific versions for those dependencies. See here:
http://docs.python.org/2/distutils/setupscript.html#relationships-between-distributions-and-packages

On Sat, Jan 25, 2014 at 3:11 PM, Zulko notifications@github.com wrote:

Thanks for the feedback.

I don't want Pygame to be installed because it is heavy not strictly
necessary (it is very useful for previews, yet). But indeed decorator
could be installed with pip. Numpy, the second important dependency, could
also be auto-installed.

I don't remember how you ask pip for automatic installs (preferentially
with no re-install if the package is already installed). Do you happen to
know how to do that ?

In the meantime I will update the docs.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-33298954
.

@Zulko
Copy link
Owner

Zulko commented Jan 25, 2014

That's what I had done, but in my memories it used to re-install my numpy... Maybe I did something wrong at the time. I am trusting you on this one.

Thanks !

@Zulko
Copy link
Owner

Zulko commented Jan 25, 2014

Just pushed the changes, I hope it does the trick. I'll wait a little before closing the issue.

@alexflint
Copy link
Author

Thanks zulcko.

On Sat, Jan 25, 2014 at 3:49 PM, Zulko notifications@github.com wrote:

Just puched the changes, I hope it does the trick. I'll wait a little
before closing the issue.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-33300213
.

@Zulko
Copy link
Owner

Zulko commented Jan 27, 2014

Ok it was still buggy but now I think I fixed it for good. Fingers crossed. I am closing the issue. Thank you for the feedback.

@Zulko Zulko closed this as completed Jan 27, 2014
mbeacom pushed a commit that referenced this issue Feb 15, 2017
merge most recent from zulko
ghost pushed a commit that referenced this issue Feb 23, 2017
tburrows13 pushed a commit that referenced this issue Mar 2, 2017
* Changed the `col` paramater of `ColorClip` to `color` and added a DeprecationWarning if the users tries to use `col`

* Update VideoFileClip.py

* Added warnings

* Update (#3)

* Fixed copy-paste typo

Changed documentation for the color parameter to distinguish from bg_color

* Fixed missing list

(using python 3)

* fixed module hierarchy for Trajectory

* fixed addy

* small recipe

* on_color function docstring has wrong parameter

The docstring for the on_color method has a parameter of bg_color but
the function uses color as the parameter.

* Update README.rst

Changed Code Block to use Python Syntax Highlighting

* fix deprecation message

currently, the docstring is nonsense. 

```
The function ``concatenate_videoclips`` is deprecated and is kept temporarily for backwards compatibility.
Please use the new name, ``concatenate_videoclips``, instead.
```

* ImageSequenceClip: Check for fps and durations rather than fps and duration

* Add a test case.

* Add another test

* ensures int arguments to np.reshape; closes #383

* fix issue #401

*  fix issue #335

* Update maintainer section in README

* make concatenate_videoclips Python 3 compatible..  fix issue #313

* Increment release version

* CompositeVideoClip doesn't accept an argument of transparent

* move PY3 variable to compat.py

* fix movie => moviepy typo

* fix issue #341

* Fixed typo #375

#375 fixed

* fix issue #357, which makes real problem more obvious (media file does not exist

* Revert "small recipe (mirroring a video)"

* Fixed indentation

* .gitignore ignore Mac-specific files, Jetbrains settings dir

* README.rst make mention of Gitter, add PyPI and Gitter badge

* README.rst wording, formatting

* README.rst structure link targets, add co-maintainers (with @username)

* README.rst move maintainers, contributing sections; change docs x-reference name

* README.rst fix grammar

* fix issue 145.  raise Exception when concatenate method != chain or compose

* make PEP8 compatible

* fix PR #413 . (issue #357)

* create test for issue #145

* add tests/media to .gitignore

* fix Issue #385 ,  no DirectoryClip class (#434)

* fix issue #385 , no DirectoryClip class

* replace DirectoryClip with ImageSequenceClip

* fix issue 417, unicode has no attribute 'shape' error.

* add test for issue 417

* add test for issue 417

* Fixed resize documentation issue #319 (#346)

* Handle bytes when listing fonts in VideoClip.py (#306)

Handle bytes when listing fonts in VideoClip.py

* add test for PR306

* add test for PR306 (#440)

* create test file for pull requests (#433)

* Test issue 407 (video has a valid fps after concatenate function) (#443)

* Move PR test to test_PR.py file (#444)

* move PR test from test_issues.py to test_PR.py

* add code to download python_logo.png

* remove duplicate test_issue_417 function

* add testing with travis-ci (#447)

added testing via travis-ci

* put DEVNULL into compat.py (#432)

* add travis-ci badge to readme file

* pick highest fps when concatenating (#416)

* readers.py cast chunksize from float to int

* choose highest fps of clips when concatenating

* pick highest fps when concatenating

* pick highest fps when concatenating

* fps either max or none

* remove resolve markers

removed resolve markers such as HEAD, etc so that the file will compile correctly.
Remove some double blank lines, etc

* update concatenate.py; add c.fps is not None

* add test for issue 416

* fix test_issue_416

* Update Gloin (#4)

* Fixed copy-paste typo

Changed documentation for the color parameter to distinguish from bg_color

* Fixed missing list

(using python 3)

* fixed module hierarchy for Trajectory

* fixed addy

* small recipe

* on_color function docstring has wrong parameter

The docstring for the on_color method has a parameter of bg_color but
the function uses color as the parameter.

* Update README.rst

Changed Code Block to use Python Syntax Highlighting

* fix deprecation message

currently, the docstring is nonsense. 

```
The function ``concatenate_videoclips`` is deprecated and is kept temporarily for backwards compatibility.
Please use the new name, ``concatenate_videoclips``, instead.
```

* ImageSequenceClip: Check for fps and durations rather than fps and duration

* Add a test case.

* Add another test

* ensures int arguments to np.reshape; closes #383

* fix issue #401

*  fix issue #335

* Update maintainer section in README

* make concatenate_videoclips Python 3 compatible..  fix issue #313

* Increment release version

* CompositeVideoClip doesn't accept an argument of transparent

* move PY3 variable to compat.py

* fix movie => moviepy typo

* fix issue #341

* Fixed typo #375

#375 fixed

* fix issue #357, which makes real problem more obvious (media file does not exist

* Revert "small recipe (mirroring a video)"

* Fixed indentation

* .gitignore ignore Mac-specific files, Jetbrains settings dir

* README.rst make mention of Gitter, add PyPI and Gitter badge

* README.rst wording, formatting

* README.rst structure link targets, add co-maintainers (with @username)

* README.rst move maintainers, contributing sections; change docs x-reference name

* README.rst fix grammar

* fix issue 145.  raise Exception when concatenate method != chain or compose

* make PEP8 compatible

* fix PR #413 . (issue #357)

* create test for issue #145

* add tests/media to .gitignore

* fix Issue #385 ,  no DirectoryClip class (#434)

* fix issue #385 , no DirectoryClip class

* replace DirectoryClip with ImageSequenceClip

* fix issue 417, unicode has no attribute 'shape' error.

* add test for issue 417

* add test for issue 417

* Fixed resize documentation issue #319 (#346)

* Handle bytes when listing fonts in VideoClip.py (#306)

Handle bytes when listing fonts in VideoClip.py

* add test for PR306

* add test for PR306 (#440)

* create test file for pull requests (#433)

* Test issue 407 (video has a valid fps after concatenate function) (#443)

* Move PR test to test_PR.py file (#444)

* move PR test from test_issues.py to test_PR.py

* add code to download python_logo.png

* remove duplicate test_issue_417 function

* add testing with travis-ci (#447)

added testing via travis-ci

* put DEVNULL into compat.py (#432)

* add travis-ci badge to readme file

* pick highest fps when concatenating (#416)

* readers.py cast chunksize from float to int

* choose highest fps of clips when concatenating

* pick highest fps when concatenating

* pick highest fps when concatenating

* fps either max or none

* remove resolve markers

removed resolve markers such as HEAD, etc so that the file will compile correctly.
Remove some double blank lines, etc

* update concatenate.py; add c.fps is not None

* add test for issue 416

* fix test_issue_416

* Update VideoFileClip.py

* Added test

* Added return for PEP 8 compliance

* Change
tburrows13 pushed a commit that referenced this issue Mar 6, 2017
* Fixed copy-paste typo

Changed documentation for the color parameter to distinguish from bg_color

* Fixed missing list

(using python 3)

* fixed module hierarchy for Trajectory

* fixed addy

* small recipe

* on_color function docstring has wrong parameter

The docstring for the on_color method has a parameter of bg_color but
the function uses color as the parameter.

* Update README.rst

Changed Code Block to use Python Syntax Highlighting

* fix deprecation message

currently, the docstring is nonsense. 

```
The function ``concatenate_videoclips`` is deprecated and is kept temporarily for backwards compatibility.
Please use the new name, ``concatenate_videoclips``, instead.
```

* ImageSequenceClip: Check for fps and durations rather than fps and duration

* Add a test case.

* Add another test

* ensures int arguments to np.reshape; closes #383

* fix issue #401

*  fix issue #335

* Update maintainer section in README

* make concatenate_videoclips Python 3 compatible..  fix issue #313

* Increment release version

* CompositeVideoClip doesn't accept an argument of transparent

* move PY3 variable to compat.py

* fix movie => moviepy typo

* fix issue #341

* Fixed typo #375

#375 fixed

* fix issue #357, which makes real problem more obvious (media file does not exist

* Revert "small recipe (mirroring a video)"

* Fixed indentation

* .gitignore ignore Mac-specific files, Jetbrains settings dir

* README.rst make mention of Gitter, add PyPI and Gitter badge

* README.rst wording, formatting

* README.rst structure link targets, add co-maintainers (with @username)

* README.rst move maintainers, contributing sections; change docs x-reference name

* README.rst fix grammar

* fix issue 145.  raise Exception when concatenate method != chain or compose

* make PEP8 compatible

* fix PR #413 . (issue #357)

* create test for issue #145

* add tests/media to .gitignore

* fix Issue #385 ,  no DirectoryClip class (#434)

* fix issue #385 , no DirectoryClip class

* replace DirectoryClip with ImageSequenceClip

* fix issue 417, unicode has no attribute 'shape' error.

* add test for issue 417

* add test for issue 417

* Fixed resize documentation issue #319 (#346)

* Handle bytes when listing fonts in VideoClip.py (#306)

Handle bytes when listing fonts in VideoClip.py

* add test for PR306

* add test for PR306 (#440)

* create test file for pull requests (#433)

* Test issue 407 (video has a valid fps after concatenate function) (#443)

* Move PR test to test_PR.py file (#444)

* move PR test from test_issues.py to test_PR.py

* add code to download python_logo.png

* remove duplicate test_issue_417 function

* add testing with travis-ci (#447)

added testing via travis-ci

* put DEVNULL into compat.py (#432)

* add travis-ci badge to readme file

* pick highest fps when concatenating (#416)

* readers.py cast chunksize from float to int

* choose highest fps of clips when concatenating

* pick highest fps when concatenating

* pick highest fps when concatenating

* fps either max or none

* remove resolve markers

removed resolve markers such as HEAD, etc so that the file will compile correctly.
Remove some double blank lines, etc

* update concatenate.py; add c.fps is not None

* add test for issue 416

* fix test_issue_416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants