Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Charles metrics in Prometheus don't have x-circle-source #162

Closed
apucci opened this issue Jun 24, 2020 · 1 comment · Fixed by #239
Closed

Charles metrics in Prometheus don't have x-circle-source #162

apucci opened this issue Jun 24, 2020 · 1 comment · Fixed by #239
Assignees
Labels
bug Something isn't working severity/critical

Comments

@apucci
Copy link
Contributor

apucci commented Jun 24, 2020

Describe the bug
When the Prometheus read metrics exposed by Istio, the label x-circle-source is not present, the problem may be Istio generating telemetry data before passing by Envoy, so that, the envoy virtual host still hasn't put the header x-circle-source in the request.

To Reproduce

  1. Do a request in an application that was deployed by Charles;
  2. Look in Prometheus the presence of the x-circle-source in the metric istio_charles_requests_total;
  3. See that the header is not being set.

Expected behavior
The header must be set before telemetry data is generated.

Your Environment

  • CharlesCD version used: 0.2.12
@apucci apucci added the bug Something isn't working label Jun 24, 2020
@apucci
Copy link
Contributor Author

apucci commented Jun 24, 2020

@apucci apucci changed the title Virtualservice not setting x-circle-source header Charles metrics in Prometheus don't have x-circle-source Jun 29, 2020
Bugs, stability and improvement automation moved this from High priority to Closed Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working severity/critical
Development

Successfully merging a pull request may close this issue.

3 participants