Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Charles is undeploying unused components before confirming that the whole release was deployed succesfully #165

Closed
lucasbfernandes opened this issue Jun 24, 2020 · 1 comment · Fixed by #228
Assignees
Labels
bug Something isn't working butler Improvements/additions/fixes for butler module. severity/critical

Comments

@lucasbfernandes
Copy link
Contributor

Describe the bug
When deploying a new release, Charles first deploys the Kubernetes pods and then triggers the Virtual Service deployment if ALL previous deployments worked correctly. If any component deployment fails, the Virtual Service deployment is not triggered and therefore the previous state of the cluster should be preserved.

During the first deployment phase, if the new deployment resulted in any unused versions, they are all undeployed immediately, which is not correct, because there is a chance the new deployment will not be used (Explained in the first paragraph).

To Reproduce
Steps to reproduce the behavior:

  1. Prepare one cluster with only 3 components deployed
  2. Deploy a release with new versions from the same 3 components described in step 1
  3. Expect one component deployment to fail
  4. See the virtual service pointing to inexistent versions in the cluster

Possible Solution
Move undeployment step to the same pipeline used for deploying the Virtual Service/Destination Rules

@lucasbfernandes lucasbfernandes added bug Something isn't working butler Improvements/additions/fixes for butler module. labels Jun 24, 2020
@lucasbfernandes lucasbfernandes self-assigned this Jul 1, 2020
@lucasbfernandes
Copy link
Contributor Author

Created a fix: #228.

Bugs, stability and improvement automation moved this from High priority to Closed Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working butler Improvements/additions/fixes for butler module. severity/critical
Development

Successfully merging a pull request may close this issue.

2 participants