This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Charles is undeploying unused components before confirming that the whole release was deployed succesfully #165
Labels
bug
Something isn't working
butler
Improvements/additions/fixes for butler module.
severity/critical
Projects
Describe the bug
When deploying a new release, Charles first deploys the Kubernetes pods and then triggers the Virtual Service deployment if ALL previous deployments worked correctly. If any component deployment fails, the Virtual Service deployment is not triggered and therefore the previous state of the cluster should be preserved.
During the first deployment phase, if the new deployment resulted in any unused versions, they are all undeployed immediately, which is not correct, because there is a chance the new deployment will not be used (Explained in the first paragraph).
To Reproduce
Steps to reproduce the behavior:
Possible Solution
Move undeployment step to the same pipeline used for deploying the Virtual Service/Destination Rules
The text was updated successfully, but these errors were encountered: