Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught ReferenceError: exports is not defined #231

Closed
BrandonRoehl opened this issue Jul 3, 2017 · 5 comments
Closed

Uncaught ReferenceError: exports is not defined #231

BrandonRoehl opened this issue Jul 3, 2017 · 5 comments

Comments

@BrandonRoehl
Copy link
Contributor

screen shot 2017-07-03 at 2 41 36 pm

Uncaught ReferenceError: exports is not defined occurs 34 different times when using

gem 'foundation-rails' , '6.4.1.0'

The screenshot is from a completely new and blank app

rails new app-name
cd app-name
echo "gem 'foundation-rails' , '6.4.1.0'" > Gemfile
bundle install
rails g foundation:install
rails s

Then there are errors
@Yanchek99
Copy link
Contributor

This appears to be an issue with how the rake task is moving the bower_components into the vendor assets folder. Is there a reason we load each individually from bower_components/foundation-sites/js rather then just use the foundation.js from bower_components/foundation-sites/dist/js/foundation.js

@BrandonRoehl
Copy link
Contributor Author

OK I'm making a fork and attempting to fix this then. Do you know how to add a pull request to the issue?

@BrandonRoehl BrandonRoehl mentioned this issue Jul 5, 2017
Merged
@BrandonRoehl
Copy link
Contributor Author

I made a pull request at #232

moroz pushed a commit to moroz/hatarake that referenced this issue Jul 11, 2017
@oKarolMoroz
Revert foundation-rails to 6.3.1.0
22f6cbc 
This is a quick fix to the error in JS that prevented the use of all JS
components of Foundation. It showed 'exports is not defined' in JS
console. This issue has been adressed here:
foundation/foundation-rails#231
@clay-f
Copy link

clay-f commented Jul 12, 2017

+1

1 similar comment
@rgrabowski
Copy link

+1

@BrandonRoehl BrandonRoehl mentioned this issue Jul 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Yanchek99 @rgrabowski @clay-f @BrandonRoehl