Require "core" first since it's needed by other modules #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deckluhm
changed the title
|
Thanks @Deckluhm ✨ |
mehlah
pushed a commit
that referenced
this pull request
Jan 13, 2016
Require "core" first since it's needed by other modules
|
Releasing some time today just trying to fix a couple errors that are found in the Travis build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First, thanks a lot for Foundation 6 and for updating this gem!
There is an error in the order files are required here : https://github.com/zurb/foundation-rails/blob/master/vendor/assets/js/foundation.js
This causes an error for
abide,accordionandaccordionMenuwhich are required beforecore.It has been fixed by @kball here : 086e336
But then changed again here : 80388ff
Thanks!