Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic position of reveal on small screens #10662

Closed
DanielRuf opened this issue Sep 19, 2017 · 5 comments
Closed

automatic position of reveal on small screens #10662

DanielRuf opened this issue Sep 19, 2017 · 5 comments
Labels

Comments

@DanielRuf
Copy link
Contributor

We use the reveal with the full class and so far it looks good in the mobile preview in Chrome on desktop. But when we tested it on a Nexus 5 the reveal had a gap at the top and started 51px beneath the start of the body/html element.

@mattbag
Copy link

mattbag commented Sep 20, 2017

Yes I had something like that too. Temporary solved upon creating a new class, and adding the scss mixins for reveal and reveal full.

@rafibomb
Copy link
Member

Isn't the reveal already full screen on mobile devices? What happens when you use no .full class? What is your use-case, are you making it full screen an all sizes?

@DanielRuf
Copy link
Contributor Author

Isn't the reveal already full screen on mobile devices? What happens when you use no .full class? What is your use-case, are you making it full screen an all sizes?

There is no real difference as it seemed.

Related: #9763

@rafibomb
Copy link
Member

Yup - that makes sense and thanks for the link. Looks like @coreysyms offered a helpful solution that people can try.

@DanielRuf
Copy link
Contributor Author

Generally the generated top is still the issue. I might check and propose a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants