Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Function ms is missing argument $base-size. #788

Closed
thomasklemm opened this issue Aug 12, 2012 · 24 comments
Closed

Error: Function ms is missing argument $base-size. #788

thomasklemm opened this issue Aug 12, 2012 · 24 comments

Comments

@thomasklemm
Copy link
Contributor

Hey,

several people seem to get an error Function ms is missing argument $base-size while precompiling their assets when upgrading gems lately.

DeAndre Johnson has made out that this occurs to some implementation changes in the sass gem that happened somewhere between 3.2.0.alpha244 and 3.2.0 that has been released yesterday.

He posted a temporary patch here.

# Gemfile
gem 'sass', '3.2.0.alpha244'
gem 'zurb-foundation', '3.0.8'
@matthewblack
Copy link

+1

@kenany
Copy link

kenany commented Aug 12, 2012

👍

Temporary patch does work.

@evantravers
Copy link

+1, and temp patch does work.

@thomasklemm
Copy link
Contributor Author

There's an even better way, the problem seems fixed: Just update the modular-scale gem.

# Gemfile
# remove gem 'sass'
gem 'zurb-foundation', '3.0.8'

Running $ bundle update should update the modular-scale gem to 1.0.2 where stuff works together neatly.
If you are not using Rails / Bundler you can update by running $ gem update modular-scale.

Thanks to DeAndre Johnson for posting this solution on Google Groups.

@kenany
Copy link

kenany commented Aug 13, 2012

Hey, if you're using Compass

Compass is still on Sass 3.1, so you can't use the latest modular-scale because it requires Sass 3.2. For the time being, unless you've already upgraded to 3.0.8, you should probably keep foundation at 3.0.7. If you already upgraded (like I did) before realizing this whole Compass issue, you just gotta hold on until Compass updates.


Edit

Nevermind, see my follow-up

@hatefulcrawdad
Copy link

I'm not having any problems with Sass 3.2 and modular scale actually. Anyone else still seeing this?

@EnigmaSolved
Copy link
Contributor

I'm on Windows and using Compass (and Foundation 3.0.8) and have not had any problems. I don't know what version of Sass is being used in my Compass install, but upgrading from 3.0.7 to 3.0.8 worked fine (other than a few unrelated odds & ends I've posted about elsewhere).

@mhair
Copy link

mhair commented Aug 13, 2012

I'm running compass v 0.12.2. It reports sass v 3.2.0.

I did a gem update, then a project update using "compass install -r zurb-foundation foundation/upgrade --force". I did receive an error on updating both app.scss and foundation.scss, which was in line 7 both times from the _globals.scss import, reporting "Function ms is missing argument $base-size.

So would that patch still be indicated considering I already have Sass 3.2 (alpha 261 per the folder create inside gems folder), is this this a different problem altogether? By the way, the gem update did bring in modular scale 1.0.2 automatically.

@kenany
Copy link

kenany commented Aug 14, 2012

Sorry about my Compass comment. My Rakefile runs the compass command whenever I do bundle exec rake generate. My problem stemmed from within the Rakefile, where it should have been running bundle exec compass, not simply compass.

@mhayes
Copy link
Contributor

mhayes commented Aug 15, 2012

There were some issues with certain alpha builds of sass when combined with modular-scale. Foundation 3.0.9 locks down the dependencies and will resolve these issues. Cheers!

@mhayes mhayes closed this as completed Aug 15, 2012
@thomasklemm
Copy link
Contributor Author

Thanks!

@thomasklemm
Copy link
Contributor Author

A note for people updating: Sass 3.2.0 final has an issue when running on the pow development server

Bug reports:

@thomasklemm
Copy link
Contributor Author

Regarding the upgrade issue for Rails / Pow users: It can be resolved by explicitly setting gem 'sass', '3.3.0.alpha.2'. This fix just arrived and upgrading to foundation 3.0.9 works smoothly.

@mearleycf
Copy link

I'm still seeing this. I did do the gem updates also (to 3.09, modular scale 1.0.2).
Updating installed gems
Updating chunky_png
Successfully installed chunky_png-1.2.6
Updating sass
Successfully installed sass-3.2.1
Updating zurb-foundation
Successfully installed sassy-math-1.2
Successfully installed modular-scale-1.0.2
Successfully installed zurb-foundation-3.0.9
Gems updated: chunky_png, sass, sassy-math, modular-scale, zurb-foundation
Installing ri documentation for chunky_png-1.2.6...
Installing ri documentation for sass-3.2.1...
Installing ri documentation for sassy-math-1.2...
Installing ri documentation for modular-scale-1.0.2...
Installing ri documentation for zurb-foundation-3.0.9...
Installing RDoc documentation for chunky_png-1.2.6...
Installing RDoc documentation for sass-3.2.1...
Installing RDoc documentation for sassy-math-1.2...
Installing RDoc documentation for modular-scale-1.0.2...
Installing RDoc documentation for zurb-foundation-3.0.9...

@thomasklemm
Copy link
Contributor Author

@mearleycf Seeing the $base-size problem or something else?

@mearleycf
Copy link

Syntax error: Function ms is missing argument $base_size.
on line 7 of /foo/.compass/extensions/zurb-foundation/stylesheets/foundation/common/_globals.scss
from line 1 of /foo/.compass/extensions/zurb-foundation/stylesheets/foundation/common/_base.scss
from line 14 of /foo/.compass/extensions/zurb-foundation/stylesheets/foundation.scss
from line 5 of /foo/Dropbox/Documents/bar/sass/app.scss

@thomasklemm
Copy link
Contributor Author

Did you run the update post-update procedure described in the docs?
http://foundation.zurb.com/docs/gem-install.php#installing

$ cd /path/to/your-project
$ compass install -r zurb-foundation foundation/upgrade --force

Note: As of August 10, 2012 and 3.0.8, when you upgrade an existing project 
you'll lose your custom settings. It's a good idea to copy your _settings.scss file 
for backup before you upgrade.

@mearleycf
Copy link

mike-imac:dreamer_justice_fix mike$ compass install -r zurb-foundation foundation/upgrade --force
error sass/app.scss (Line 7 of _globals.scss: Function ms is missing argument $base-size.)
overwrite stylesheets/app.css
error sass/archive/app.scss (Line 7 of _globals.scss: Function ms is missing argument $base-size.)
overwrite stylesheets/archive/app.css

@thomasklemm
Copy link
Contributor Author

@mearleycf Sorry, no idea then.

@kelicia
Copy link
Contributor

kelicia commented Sep 13, 2012

I'm seeing this issue too.

*sass-3.2.0
*compass-0.12.2
*zurb-foundation-3.0.9
*modular-scale-1.0.2

Function ms is missing argument $base-size.

@lewiswharf
Copy link

I cannot get rid of this error:

Function ms is missing argument $base-size

I'm on Windows 7. I installed Ruby 1.9.3-p286, opened up the command prompt and ran

gem install zurb-foundation

Then I created a project using

compass create assets -r zurb-foundation --using foundation

In addition to the error message, looking at _settings.scss tells me that Foundation 3.2 is not used but rather Foundation 3.0.

I have followed this thread and tried all the suggestions that are apparent to me. Anyone else experiencing this still?

@lewiswharf
Copy link

Ok, my setup had a .compass folder with Foundation 3.0 causing all the problems. Sorry for the false alarm..

@sethburtonhall
Copy link

Yes, I am experiencing this as well. Any solution?

Is this a CodeKit issue or a gem version issue?

@sethburtonhall
Copy link

#775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests