-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button group] radius doesn't wrap the whole group, but each one! #8447
Comments
Perfect! I was just fixing this bug locally! |
Hmm… I'm not sure if this is a bug. This makes an assumption that you don't want each button to have its own radius. That definitely makes sense for Split Buttons (w/ the arrow). But if I suppose having the radius only on the group does help to associate the buttons with each other as a group. But I'm still not sure if the radius should go on the group or on each button. Maybe what's needed is a Honestly, I'm for dropping |
@andycochran I guess we could add another variable, to make this behavior optional. Though personally I think, the given Example of a split button shows quite clearly, that removing the radius inside the group is the typically expected behavior. Just for Illustration purposes. This is a split button: As for dropping the radius Considering how many developers use this framework already, i would strongly advice against dropping such a central property. |
@abdullahsalem How about adding a variable Wrapping a your code additions into a condition This way the code isn't added to the final CSS code, where it is not needed. Keeping the results as lean as possible. |
^ In that group of GitHub buttons, each button has its own radius. But again, I totally agree that split buttons should have their radius on the group. The reason I'm for dropping Although, I really doubt dropping The Zurb team probably needs to discuss internally and weigh in on this. * Sorry for the "split" pun. 😊 |
He he! Well, I guess until be have Feedback from ZURB, we can only work with what is given: The current implementation of the button-group highly suggest, that the button group is intended as a closed group of buttons, acting as one. Not a group of separate buttons, in a lose relation to each other. You can see that, if you ramp up the calue of The spacing is implemented by changing the size of the buttons To cover both use cases, this should be changed to use margin-right for the spacing. I wouldn't use the Introducing |
I adapted the code of @abdullahsalem to include a Check it out here: https://github.com/g12n/foundation-sites/commit/65a4d88d43d8bd7205430f8e4a71d551b749b911
Please give me a quick feedback, before i initialize a pull request. |
Thank you for your contributing @g12n @andycochran, |
Hi guys,
|
@abdullahsalem Fair point. But that perspective certainly devalues the function of Button Groups that don't have any radius. Hmm… I've been working on a write-up, trying to sort this all out: (My next step: take an inventory of every function that Button Groups & Menus have/need in order to assess a rewrite.) |
Thank you very much @andycochran, you did a great work on that codepen. I am really not sure if the assumption of multiple lines should be considered in such this component, but I currently don't think so. Therefore, I might choose either option B or C, but I would prefer C if the multiple-lines is accidentally happened. |
Given how much of this is opinion based depending on the details of your app, I kind of wonder if it would be good enough to add a little tutorial on how to implement these either as custom classes or as extensions to the base classes. One thing that gets lost sometimes is how much Foundation is intended to be just that - a foundation - not the be-all and end-all. If we can give more guidance about how to extend it and build on top of it, some of these issues may become less pressing. |
Fixed in #9031. Will be in 6.3 |
I think that when the radius is applied on the button group, it should appear as a wrapper for the whole group not each one!
How can we reproduce this bug?
What did you expect to happen?
![button-group-container-radius](https://cloud.githubusercontent.com/assets/177020/13958084/d7206a84-f05f-11e5-9961-ae49585d3f6c.png)
What happened instead?
![button-group-container-radius-issue](https://cloud.githubusercontent.com/assets/177020/13958597/bf4e8236-f061-11e5-8b23-bfc450167991.png)
The text was updated successfully, but these errors were encountered: