Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reveal] Feature Request: Make appendTo("body") configurable #9046

Closed
phifa opened this issue Jul 25, 2016 · 4 comments
Closed

[Reveal] Feature Request: Make appendTo("body") configurable #9046

phifa opened this issue Jul 25, 2016 · 4 comments

Comments

@phifa
Copy link
Contributor

phifa commented Jul 25, 2016

For ajax loading reasons I need all of me content inside a specific div. Problem is, the reveal plugins always gets attached to the body. When I change the code in line 88 in founation.reveal.js like this it works like a charm:

  _makeOverlay(id) {
    var $overlay = $('<div></div>')
                    .addClass('reveal-overlay')
                    .appendTo('#configurableDiv');
    return $overlay;
  }
@Owlbertz
Copy link
Contributor

That would be a nice enhancement for v6.3. You think you could create a PR for this?

@phifa
Copy link
Contributor Author

phifa commented Jul 26, 2016

like so @Owlbertz #9050 ?

@phifa
Copy link
Contributor Author

phifa commented Aug 9, 2016

I did it again, this time with the newest version -.-

#9094 @Owlbertz

@kball
Copy link
Contributor

kball commented Nov 1, 2016

Fixed with #9094

@kball kball closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants