Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select icon in chrome #9968

Closed
captain-xu opened this issue Apr 20, 2017 · 10 comments
Closed

select icon in chrome #9968

captain-xu opened this issue Apr 20, 2017 · 10 comments
Assignees
Labels

Comments

@captain-xu
Copy link

There two icons in chrome , the select should add -webkit-apperance: none

@Deckluhm
Copy link
Contributor

As stated here, vendor prefixes aren't included in Sass sources.

@kball
Copy link
Contributor

kball commented Apr 20, 2017

We can if necessary to fix a bug... can you put in a reproduction codepen?

@Deckluhm
Copy link
Contributor

Deckluhm commented Apr 20, 2017

We can if necessary to fix a bug... can you put in a reproduction codepen?

The "bug" is only visible if you use the Sass version of Foundation (since there is no vendor prefixes in sources) and as far as I know, there is no easy way to import a full Sass project in CodePen.

I reproduced the "bug" @captain-xu is talking about by using Foundation CSS version and by setting select -webkit-appearance to the default WebKit value (menulist):

https://codepen.io/anon/pen/EmKZgW?editors=1100

@captain-xu
Copy link
Author

@Deckluhm that's right, there are no problems if use the css. And I think, the select -webkit-appearance show be 'none'

@kball
Copy link
Contributor

kball commented Apr 21, 2017

@IamManchanda I think this is similar to the fix you did in #9868 - do you want to take a pass on it?

@IamManchanda
Copy link
Contributor

Ohk @kball will take a look!

@IamManchanda
Copy link
Contributor

IamManchanda commented May 22, 2017

@captain-xu @Deckluhm
I couldn't reproduce in the sass build codepen!
https://codepen.io/IamManchanda/pen/wdQVoB
(As this is a Sass Build with all of foundation code, codepen takes a bit of time to open)

Apart from that i have added test case here (where also i cant see the bug) #10063
Can you pull it and let me know with screenshot and browser details ??

@rafibomb
Copy link
Member

@Deckluhm Hmm, as far as I know, Autoprefixer is running on the ZURB Stack and Basic Template. You can see it here,
https://github.com/zurb/foundation-zurb-template/blob/master/gulpfile.babel.js#L84
https://github.com/zurb/foundation-sites-template/blob/master/gulpfile.js#L17

If you are not auto-prefixing, then manually adding the vendor prefixes would be good.

I am also seeing the correct declarations in my 6.3.1 project:
screen shot 2017-05-22 at 10 22 42 am

Unless I'm missing something, let me know - we'll close this.

@Deckluhm
Copy link
Contributor

Hmm, as far as I know, Autoprefixer is running on the ZURB Stack and Basic Template.

Sorry if I wasn't clear enough, here are my thoughts about the issue reported:

  • It's not a bug
  • It only appears on Sass version without Autoprefixer, basically anything except ZURB Stack (e.g. foundation-rails gem)
  • As stated in the docs, unless you are using the ZURB Stack (that already includes Autoprefixer), you must use Autoprefixer to get vendor prefixes

That is probably a good idea to add a small note in the docs about that. I already faced that "double icon" issue and it wasn't obvious that it was a prefixes issue.

@IamManchanda
Copy link
Contributor

IamManchanda commented May 22, 2017

That is probably a good idea to add a small note in the docs about that. I already faced that "double icon" issue and it wasn't obvious that it was a prefixes issue.

@Deckluhm you are correct 👍 ..... Go ahead and add a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants