-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #9871: Flex Topbar #10056
Closes #9871: Flex Topbar #10056
Conversation
@kball ,,,, i think the docs update should go in master (live) also! |
@rafibomb can you take a look at this? |
@@ -42,7 +42,7 @@ $titlebar-icon-spacing: 0.25rem !default; | |||
|
|||
@if $global-flexbox { | |||
display: flex; | |||
justify-content: space-between; | |||
justify-content: flex-start; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this should be start (left align)
By default I think it should be space-between is you had 2 sides like:
http://foundation.zurb.com/sites/docs/off-canvas.html#combining-with-title-bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, this component can be manipulated with the flex helper classes. I think title bar should get it's own docs page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see when you dont use title bar left or right then flex start makes sense. I've added to your test case to demonstrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So shall we insert this in a variable ?
@rafibomb?
and keep flex start?
And some docs about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On title bar docs, yes I agree infact having same discussion about it at #9991
I don't know how I feel about removing the all in one responsive toggle docs example - it's nice to have but I get it needs work for flex version |
It looks good from a bug fix perspective - merging! What I'd like to see in the future:
Thoughts? @IamManchanda @kball @brettsmason @andycochran @colin-marshall |
This closes #9871.
The new docs codepen example already fixes this.
This just adds
Here is the flex version codepen (with titlebar tweaks) => https://codepen.io/IamManchanda/pen/OmBVZE?editors=1100