Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #10333 #10335

Merged
merged 1 commit into from Jul 4, 2017
Merged

Fixed #10333 #10335

merged 1 commit into from Jul 4, 2017

Conversation

hikouki
Copy link

@hikouki hikouki commented Jul 4, 2017

Fixed #10333 馃崳

@IamManchanda
Copy link
Contributor

Thanks @hikouki ... let me dig in and merge it!

@IamManchanda IamManchanda self-requested a review July 4, 2017 14:57
Copy link
Contributor

@IamManchanda IamManchanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@IamManchanda
Copy link
Contributor

Awesome work @hikouki
See if you would want to take up #10106 also ??

@hikouki
Copy link
Author

hikouki commented Jul 5, 2017

Thank yout for merge! 鉁堬笍

I'd like to contribute it.
But, I can't write English well. 馃檱
I think it is difficult. Sorry...

@kball
Copy link
Contributor

kball commented Jul 5, 2017

Awesome! Congratulations on first merged PR @hikouki!

@IamManchanda
Copy link
Contributor

Not an issue @hikouki What we care is writting code instead of English 馃槈

@IamManchanda
Copy link
Contributor

You try once ... I am there to help you out @hikouki in english/code/etc!

@hikouki
Copy link
Author

hikouki commented Jul 5, 2017

Okay, I'll give it a try.
Thank you for giving me a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants