chore: remove the deprecated positionClass in tooltip #11067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And yes, good for v6.4.4 since we break nothing (already broken) but simply clean the code. |
|
Note: |
DanielRuf
deleted the
chore/tooltip-remove-deprecated-position-class-11066
branch
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…-deprecated-position-class-11066 for v6.5.0 2f541a2 chore: remove the deprecated positionClass in tooltip Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
positionClasswas marked as deprecated a while ago.I propose to plan this for 6.5 as this will also introduce a change to the code and the deprecated code will be removed.
Closes #11066