fix: fix history browsing with nested Reveal and deep-linking #11093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#8012 When closing a Reveal with `replaceState: true`, push a new entry to reset the hash. So going back to the history reopen the modals opened before in reverse order. Closes foundation#8012
|
Thank you for the review |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…link-history-8012 for v6.5.0 42d267a fix: update history when closing Reveal with `replaceState` foundation#8012 88c08bd fix: prevent Reveal opening with its hash already set to add history entry d5fe114 tests: add visual tests for nested Reveal with deep-linking Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
replaceStateWhen closing a Reveal with
replaceState: true, push a new entry to reset the hash. So going back to the history reopen the modals opened before in reverse order.Closes: #8012
Visual tests are from: https://codepen.io/DanielRuf/pen/OvPpzb