Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Magellan hash resolution without active link #11142

Merged
merged 1 commit into from Apr 11, 2018
Merged

fix: fix Magellan hash resolution without active link #11142

merged 1 commit into from Apr 11, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Apr 7, 2018 •
edited

Bug

When scrolling in Kitchen Sink page:

Uncaught TypeError: Cannot read property 'getAttribute' of undefined at

Changes:

  • Check if an active link exists when trying to retrieve its hash to updating it in Magellan.

Bug was introduced in #10906.

@ncoden ncoden added this to the 6.5.0 milestone Apr 7, 2018
@ncoden ncoden requested a review from DanielRuf April 7, 2018 21:56
@ncoden ncoden mentioned this pull request Apr 7, 2018
Merged
36 tasks
@ncoden
Copy link
Contributor Author

ncoden commented Apr 11, 2018

Poke @DanielRuf. (planned for v6.5.0)

@ncoden ncoden merged commit f297c1a into foundation:develop Apr 11, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11142 from ncoden/fix/fix-magellan-withou…
a8be0aa 
…t-link for v6.5.0

f06b85b fix: fix Magellan hash resolution without active link

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
bug fix Magellan
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncoden @DanielRuf