Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revise Eyeglass compatibility range #11268

Merged
merged 1 commit into from May 16, 2018
Merged

chore: revise Eyeglass compatibility range #11268

merged 1 commit into from May 16, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 15, 2018

Description

The current Foundation codebase supports all eyeglass versions since its first stable release v0.8.0.

Changes:

  • Support eyeglass >=0.8.0 instead of ~0.8.0 in package.json

Closes #11263

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@ncoden
chore: use appropriate eyeglass compatibility range
8e1e945 
The current Foundation codebase supports all eyeglass versions since its first stable release `v0.8.0`.

Changes:
* Support eyeglass `>=0.8.0` instead of `~0.8.0` in package.json

Closes foundation#11263
@ncoden ncoden mentioned this pull request May 15, 2018
Closed
4 tasks
@ncoden ncoden requested a review from DanielRuf May 15, 2018 20:02
@ncoden ncoden merged commit dc02330 into foundation:develop May 16, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11268 from ncoden/chore/eyeglass-compatib…
2d3be86 
…le-versions-11263 for v6.5.0

8e1e945 chore: use appropriate eyeglass compatibility range

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
📦 dependencies 💻 maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

foundation needed eyeglass ^0.8.0, current eyeglass version is 1.5.0
2 participants
@ncoden @DanielRuf