chore: move jQuery & what-input to peerDependencies #11290 #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peerDependencies is for dependencies that are exposed to (and expected to be used by) the consuming code, as opposed to "private" dependencies that are not exposed, and are only an implementation detail. * We need `jQuery` and `motion-ui` as peerDependencies instead of dependencies because we actually expect the user to install them. We cannot simply remove them because we still need the package managers to check for versions compatibilities and warn the user if they are missing. * We need `jQuery` and `motion-ui` as devDependencies too because we use them for tests/build/documentation and peerDependencies are not installed (even in development mode - yarnpkg/yarn#1503). See foundation#11290
This was referenced May 22, 2018
DanielRuf
approved these changes
May 24, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…er-dependencies-11290 for v6.5.0 b1b9408 chore: move jQuery & what-input to peerDependencies foundation#11290 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
jqueryandwhat-inputfromdependenciestopeerDependencies.Motivation and Context
peerDependencies is for dependencies that are exposed to (and expected to be used by) the consuming code, as opposed to "private" dependencies that are not exposed, and are only an implementation detail.
jQueryandmotion-uias peerDependencies instead of dependencies because we actually expect the user to install them. We cannot simply remove them because we still need the package managers to check for versions compatibilities and warn the user if they are missing.jQueryandmotion-uias devDependencies too because we use them for tests/build/documentation and peerDependencies are not installed (even in development mode - Add a means to install package peer dependencies for development / testing yarnpkg/yarn#1503).Closes #11290
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).