fix: fix and update Bower config #11350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bower dependencies in `bower.json` were removed in foundation#11073 in the migration from Bower to npm. These dependencies should not have been removed as the Bower package still require `jquery` and `what-input`. Someone installing `foundation-sites` with bower should still have these packages included. We simply don't use Bower anymore in development mode and don't promote its usage in the documentation. Removing `bower install` commands was sufficiant for this migration and Bower dependencies in `bower.json` were unrelated. See foundation#11073
ncoden
force-pushed
the
fix/fix-update-bower-config
branch
from
f0c8e2a
to
e3979a3
Compare
|
Do we still want to support Bower which is dead in general? |
|
It is dead but people are still using it. So for a project as big as this one I would say: "Keep the support as long as you do not promote its usage and do not spend too much time on it." |
|
https://twitter.com/kbal11/status/805891962993713152 (but it's 1.5 years old) |
DanielRuf
approved these changes
Jun 26, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 1, 2018
Changes were introduced in foundation#11350 Closes foundation#11364
14 tasks
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Bower config file
bower.jsonand fix various issues related to outdated/incorrect configuration.Changes:
description,homepage,keywords,moduleTypeandrepositoryNote: This PR is suitable for v6.5.
Motivation and Context
Bower dependencies in
bower.jsonwere removed in #11073 in the migration from Bower to npm.These dependencies should not have been removed as the Bower package still require
jqueryandwhat-input. Someone installingfoundation-siteswith bower should still have these packages included. We simply don't use Bower anymore in development mode and don't promote its usage in the documentation.Removing
bower installcommands was sufficiant for this migration and Bower dependencies inbower.jsonwere unrelated.Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).[ ] I have updated the documentation accordingly to my changes (if relevant).[ ] I have added tests to cover my changes (if relevant).