chore: update sourcemaps of distributed JS plugins #11394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcemaps for distribution main files and build JS plugins were added in foundation#11012 but distribution JS plugins were forgotten. This commit change the `deploy:plugins` gulp task to generate and copy sourcemaps for JS plugin alongside their source files. Changes: * Split `deploy:plugins` into `deploy:plugins:sources` and `deploy:plugins:sourcemaps` * Generate sourcemaps for minified plugins in `deploy:plugins:sources` * Copy sourcemaps for plugins to dist folder in `deploy:plugins:sourcemaps`
DanielRuf
approved these changes
Jul 10, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Aug 25, 2018
…ourcemaps for v6.5.0 09a46c6 chore: update sourcemaps of distributed JS plugins Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit change the
deploy:pluginsgulp task to generate and copy sourcemaps for JS plugin alongside their source files.Changes:
deploy:pluginsintodeploy:plugins:sourcesanddeploy:plugins:sourcemapsdeploy:plugins:sourcesdeploy:plugins:sourcemapsMotivation and Context
Sourcemaps for distribution main files and build JS plugins were added in #11012 but distribution JS plugins were forgotten.
Types of changes
functionality to change)
Checklist (all required):
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).