fix(accordion): adds role="presentation" to accordion items #11659 #11681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#11659 Adds `role="presentation"` to accordion items to comply with WAI. Includes the respective unit test. fix foundation#11659
DanielRuf
approved these changes
Feb 18, 2019
3 tasks
|
This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there: https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1 |
This was referenced Mar 10, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
role="presentation"to accordion items to comply with WAI. Includes the respective unit test.fix #11659
Description
Adds
role="presentation"to the accordion items as outlined in #11659.Includes a test within the accordion constructor describe group, it was placed within this group as it's not functionally related to any other describe group.
...
Types of changes
Checklist
developordevelop-v...).