Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the right event namespace for dropdown menu #11715

Merged
merged 1 commit into from Aug 12, 2019
Merged

fix: use the right event namespace for dropdown menu #11715

merged 1 commit into from Aug 12, 2019

Conversation

DanielRuf
Copy link
Contributor

Description

There is a different event namespace which seems to be problematic as it is not registered correctly.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf requested a review from ncoden March 6, 2019 07:40
@DanielRuf DanielRuf mentioned this pull request Mar 6, 2019
Closed
3 tasks
@iamcanadian1973 iamcanadian1973 mentioned this pull request Jul 23, 2019
Open
@kball kball merged commit 3b280c8 into foundation:develop-v6.5 Aug 12, 2019
@DanielRuf DanielRuf deleted the fix/11611-dropdown-menu-change-event-namespace branch August 12, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kball kball kball approved these changes

@ncoden ncoden Awaiting requested review from ncoden

Assignees
No one assigned
Labels
Dropdown Menu javascript PR open Responsive Menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielRuf @kball