Short pages with Joyride tips bounce to top when scrolling to the next tip #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calculations to prevent bouncing back to the top in the case of a short document where the tip content itself made the document larger.
hatefulcrawdad
pushed a commit
that referenced
this pull request
Jul 9, 2013
Short pages with Joyride tips bounce to top when scrolling to the next tip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page is short enough (or the tip is large enough), the Joyride tip can extend the length of the document. When moving to the next tip, the element was removed from the layout causing a noticeable bounce to the top of the page before scrolling to the next location.
This change ensures that the element remains hidden in the layout until the scroll has occurred.