[bugfix] Abide: dont validate hidden fields #8770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8039 where hidden fields can cause error messages to be hidden, making it unclear why a form was not submitted.
It also moves the skipping of
[data-abide-ignore]
fields to validation-time such that if that property is added or changed with javascript, it will still be respected by Abide.I welcome feedback and suggestions. Sorry I don't have time to really backfill tests for Abide.