Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced keyboard navigation for Offcanvas. #9011

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Owlbertz
Copy link
Contributor

@Owlbertz Owlbertz commented Jul 8, 2016

On open not the first element within the side panel, but the whole panel should receive focus.
If the first interactive element is focussed the user might miss some content above it, e.g. the panel heading.
Also added usage of handleKey() to the component to close the panel.
Moved the panel focussing outside of the transitionEnd listener because this was never called and it also works outside...

I would really appreciate feedback of @sethkane and @Geczy here.

On open not the first element within the side panel, but the whole panel should receive focus.
If the first interactive element is focussed the user might miss some content above it, e.g. the panel heading.
Also added usage of handleKey() to the component to close the panel.
Moved the panel focussing outside of the transitionEnd listener because this was never called and it also works outside...
@Geczy
Copy link

Geczy commented Jul 8, 2016

Took a look and that definitely makes the off canvas menus behave better under accessible software. But my issue still remains #8536

I work around it by adding $('#my-info').attr('aria-hidden', 'false'); on dom ready

@Owlbertz
Copy link
Contributor Author

Owlbertz commented Jul 8, 2016

Huh, didn't saw that issue yet. Will try to get this done soon as well in the same branch.

@Owlbertz
Copy link
Contributor Author

Owlbertz commented Jul 8, 2016

@Geczy Do you work with standard visibility classes? I feel like a simple this.$element.is(':visible') check before applying the aria-hidden (and also the aria-expanded stuff I guess) would do the trick during the initialization.

@rafibomb
Copy link
Member

@Owlbertz That solution should work!

@rafibomb rafibomb added this to the 6.2.4 milestone Jul 11, 2016
@kball kball merged commit de73f6c into foundation:develop Sep 13, 2016
@mr-feek
Copy link

mr-feek commented Dec 4, 2016

since this added keyboard as a dependency to off canvas, it would have been nice to have noted that in the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants