New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last Centered Column in series floats right #1020
Comments
Despite having the .end class, there are still issues. In @dhornbein 's example above, because he's centering the columns, even if he applies the .end class, the last column will be floating to the far left. That's because .end overrides it with a float:left. There should be a class to apply float:none for centered last columns. I use Foundation on Wordpress sites, so most of my columns are dynamically generated and I don't have the ability to add a class of .end to my last column. I've of course overridden this with my own custom styles. As well, I often layout pages with thumbnail grids, and if I only have two posts in Wordpress (or whatever generates your content) then my last post thumbnail item is floated right, leaving a huge gap and throwing off the natural order of the thumbnail grid layout.
I propose that the above CSS rule be removed from Foundation. I know it's implemented to help keep columns aligned across browser inconsistencies, but I feel it's more trouble than it is helpful. Especially when dynamically generated content doesn't allow us to add a class of end. At least, since you already assume users can manually add a class of .end, then they should be able to manually add a class of .last if they want to float the last-child column to the right. Otherwise, I think the natural column order of floating left should be default for the last column. |
Hey @markcy! Thanks for the suggestion, but we're going to keep things how they are. Here's why: When you have a As for you centering problem. We didn't intend for people to use three Hope this helps! |
I have a list of centered columns:
The final one floats right. I would like them to all be centered.
[class*="column"] + [class*="column"]:last-child
overrides.column.centered, .columns.centered
and.end
simply sets the column to float left.Perhaps we could extend
.column.centered, .columns.centered, .columns.centered.end
to over ride the above behavior.Perhaps there is good reason for this NOT to be the case, no big deal :)
The text was updated successfully, but these errors were encountered: