New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem with reveal and vimeo #433
Comments
This has been submitted before but we'll need to tackle it in a larger overhaul to reveal. Reveal handles the animation right now by using visibility: hidden on the modal, which does nothing to stop embeds or other media. You would need a JS call when the modal closes to stop the included video. |
I fixed this as follows, I also added a show and hide to the vimeo video, see issue here: #727 (thanks to https://github.com/alettieri): The HTML:
The javascript:
|
@mrtunes what @smileyj68 said is a good way to tackle your problem. You could bind to the reveal:close event and use the Vimeo player API pause method to pause the video. Here's a working example of what's possible with reveal + Vimeo. Code can be found here. Hope this helps. |
my site had foundation 2.1.5 originally, and when using reveal i found that a vimeo video wouldn't stop playing after closing the modal window. so i updated the scripts app.js and foundation.js using the 2.2.1 package assuming that people had likely submitted this bug before.
now the modal window doesn't come up at all. was i supposed to add more updates into the site?
EDIT: i fixed one part of this issue by moving app and foundation to the bottom, and adding modernizr. but vimeo still keeps playing after closing the box.
The text was updated successfully, but these errors were encountered: