Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundation.min.js isn't Minified #6073

Closed
LDigital84 opened this issue Dec 2, 2014 · 7 comments
Closed

foundation.min.js isn't Minified #6073

LDigital84 opened this issue Dec 2, 2014 · 7 comments

Comments

@LDigital84
Copy link

I noticed today that if you download Foundation from the download page either downloading everything or using the custom download that the foundation.min.js file isn't minified. It contains all of the JS code but should be minified as well, correct?

I have minified it myself for my project but I assume this is a bug?

@rafibomb
Copy link
Member

rafibomb commented Dec 9, 2014

This is a known issue with Uglify on our customizer. It's a complicated beast and we're sorting it out soon.

@LDigital84
Copy link
Author

@rafibomb - Thank you for the update!

@LDigital84
Copy link
Author

@rafibomb - It may be beneficial to throw a note on the custom downloader letting people know it isn't minified and they should minify it themselves. (Until this bug is fixed.) I am doing that and saving an average of 50% of the file size! In some cases this is 50 to 70kb! Huge savings.

@dud3
Copy link

dud3 commented Jan 18, 2015

@rafibomb Which uglifier are you using, I noticed this issue as well.

@chauncey-garrett
Copy link

It'd be good to sort this out. CDNs like jsdelivr source these releases for the minified versions.

Related issue: jsdelivr/jsdelivr#3590 (comment)

@elliottb
Copy link

Upvote

@rafibomb rafibomb added this to the 5.5.2 milestone Apr 28, 2015
@rafibomb rafibomb modified the milestones: 5.5.2, 5.5.3 May 13, 2015
@rafibomb
Copy link
Member

rafibomb commented Jul 3, 2015

This has been fixed! We had update a ton of dependancies and syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants