fix bug where every valid element after an invalid was marked as invalid #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug where every valid element after an invalid element was marked/styled as invalid due the fact that the `validations` array was global and always included a `false` when a previous element was invalid.
|
@christianseel Is this the same resolution? #5606 |
rafibomb
added a commit
that referenced
this pull request
Sep 5, 2014
fix bug where every valid element after an invalid was marked as invalid
|
Sweet, nice job! |
christianseel
pushed a commit
to christianseel/foundation
that referenced
this pull request
Sep 11, 2014
This was introduced with foundation#5738. The statement was in the wrong line. This fixes a bug where the validation of radios and checkboxes was not recognized in the final validation result. Now it works great :)
Closed
|
I'm a little lost here with all these different threads...the version of abide that I JUST downloaded 10 minutes ago appears to still be showing all subsequent fields as invalid. I might add that the email validation is, from what I can tell, only half-validation: as long as it includes the "@" sign it passes as valid, even if the rest of the email string is badly formatted. Why is it not validating the full structure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where every valid element after an invalid element was marked/styled as invalid due the fact that the
validationsarray was global and always included afalsewhen a previous element was invalid.I fixed this by adding an array for each element, push all validation results to this
el_validationsand push the validation result from each element to the global arrayvalidations.