@else should be placed on same line as previous curly brace #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Standards are good - can't auto-merge this but we'll get it in soon. |
|
I just got one question. What if there is a comment above the |
|
You could move the comment inside the block, and then you'd be able to pair all the |
|
Ok, I'll fix it soon |
Conflicts: scss/foundation/components/_orbit.scss
Conflicts: scss/foundation/components/_dropdown.scss scss/foundation/components/_global.scss scss/foundation/components/_grid.scss scss/foundation/components/_switches.scss
Conflicts: js/foundation/foundation.abide.js scss/foundation/components/_range-slider.scss
|
Hey, really sorry for letting this get super stale! Now that Foundation 6 is out, we won't be making any more codebase improvements to Foundation 5. We're always looking for contributions to the new codebase, though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://sass-guidelin.es/#conditional-statements