Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Nested folders in multi-file games support #179

Closed
therobbiedavis opened this issue Apr 14, 2023 · 3 comments
Closed

[Feature] Nested folders in multi-file games support #179

therobbiedavis opened this issue Apr 14, 2023 · 3 comments
Assignees
@zurdi15
Labels
feature New feature or request

Comments

@therobbiedavis
Copy link
Contributor

RomM version
1.7

Describe the bug
The multi-file game logic introduced in v1.6.3 does not incorporate sub-folders or their files into the zip. This is necessary for PS3 Roms.

To Reproduce
Steps to reproduce the behavior:

  1. Get a PS3 Rom
  2. Add to RomM
  3. Try to download
  4. See that only first level is compressed

Expected behavior
All sub levels are included in the zip and size calculation.

Screenshots
PS3 Structure:
image
image
image

RomM View and Zip Download:
image
@therobbiedavis therobbiedavis added the bug Something isn't working label Apr 14, 2023
@therobbiedavis
Copy link
Contributor Author

therobbiedavis commented Apr 14, 2023 •
edited
Loading

I'll also say it would certainly help with switch update and dlc management as well.
image

@zurdi15
Copy link
Member

zurdi15 commented Apr 14, 2023

Hi! it needs more work to get all level files in multifile games, but it is not a bug, rigth now this is how RomM works, so I am changing it as a feature if you don't mind :)

@zurdi15 zurdi15 changed the title [Bug] Multi-file is limited to top level of game directory [Feature] Nested folders in multi-file games support Apr 14, 2023
@zurdi15 zurdi15 added feature New feature or request and removed bug Something isn't working labels Apr 14, 2023
@zurdi15 zurdi15 pinned this issue Apr 15, 2023
@zurdi15 zurdi15 mentioned this issue Apr 25, 2023
Merged
@zurdi15
Copy link
Member

zurdi15 commented Apr 26, 2023

Support for subfolders inside multi part games added in v1.8

@zurdi15 zurdi15 closed this as completed Apr 26, 2023
@zurdi15 zurdi15 unpinned this issue Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zurdi15 zurdi15

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@therobbiedavis @zurdi15