Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improved error handling of a bad folder structure #217

Closed
calebsmithdev opened this issue Apr 30, 2023 · 1 comment
Closed

[Feature] Improved error handling of a bad folder structure #217

calebsmithdev opened this issue Apr 30, 2023 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@calebsmithdev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is related to the initial project scan and immediate failing when the folder structure is setup incorrectly. In my case, I had the folder mounted but did not have a roms folder inside each platform.

Describe the solution you'd like
Instead of showing an empty error message (API resulted in a 500), show another type of error message to confirm a 500, or catch the error to show a more relevant message.

Additional context
I do not have the original log now with the failed messaging, but it was related to the function get_roms when trying to retrieve the roms for the first platform.

@calebsmithdev calebsmithdev added the feature New feature or request label Apr 30, 2023
@zurdi15 zurdi15 pinned this issue Apr 30, 2023
@zurdi15 zurdi15 unpinned this issue May 8, 2023
@zurdi15 zurdi15 pinned this issue May 8, 2023
@zurdi15 zurdi15 unpinned this issue May 14, 2023
@zurdi15 zurdi15 mentioned this issue May 17, 2023
@zurdi15
Copy link
Member

zurdi15 commented May 17, 2023

Improved in the new release v1.8.3.

@zurdi15 zurdi15 closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants