Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loader To Edit Profile Save Button #1003

Closed
wants to merge 28 commits into from

Conversation

ugoostanleyibe
Copy link
Contributor

@ugoostanleyibe ugoostanleyibe commented Oct 17, 2021

This update adds a loader (CircularProgressIndicator) to the 'Save' button in the EditProfileView as can be seen below:

demo7

There is also the General Search feature which is a work in progress and whose purpose is to enable a user search through all the messages and files in the channels they have joined. The demo can be seen below:

demo6

@github-actions
Copy link

The status is success

@jeremiahseun jeremiahseun added the Conflict Resolve Conflicts label Oct 18, 2021
@jeremiahseun
Copy link
Contributor

We will also prefer a video showing what you have implemented.

@github-actions
Copy link

The status is success

@jeremiahseun jeremiahseun removed the Conflict Resolve Conflicts label Oct 19, 2021
@jeremiahseun
Copy link
Contributor

Please show a video of what you have implemented.

@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

@jeremiahseun
Copy link
Contributor

Should we wait for you to send the updates or you will send another PR?

jeremiahseun
jeremiahseun previously approved these changes Oct 27, 2021
Copy link
Contributor

@jeremiahseun jeremiahseun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ugoostanleyibe
Copy link
Contributor Author

Should we wait for you to send the updates or you will send another PR?

I will send another PR

@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

@ugoostanleyibe ugoostanleyibe changed the title Implement General Search Add Loader To Edit Profile Save Button Oct 30, 2021
@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

Copy link
Contributor

@pauleke65 pauleke65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is doing too many things, please let it more be specific 🙏🏾.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

The status is success

@ugoostanleyibe
Copy link
Contributor Author

PR is doing too many things, please let it more be specific 🙏🏾.

Omo... me sef don tire 😵

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

The status is success

@pauleke65
Copy link
Contributor

@ugoostanleyibe Please make a separate PR for each task done here.

@pauleke65 pauleke65 closed this Nov 2, 2021
@pauleke65
Copy link
Contributor

@ugoostanleyibe Please make a separate PR for each task done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants