Feat/admin user name change functionality #2840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dminUserNameChangeFunctionality
billmal071
requested changes
Dec 10, 2022
Comment on lines
+34
to
+35
| .then(res => console.log(res)) | ||
| .catch(error => console.log(error.response)); |
There was a problem hiding this comment.
Remove console.log and console.error. Use toast to show notifications.
|
Also resolve the conflicts on your branch |
ickynavigator
requested changes
Dec 10, 2022
| event.preventDefault(); | ||
| axios | ||
| .patch( | ||
| `https://api.zuri.chat/organizations/${organization_id}/members/${user_member_id}/profile`, |
There was a problem hiding this comment.
use the base url constant provided in the app
it should be coming from @zuri-utilities
| } | ||
| } | ||
| ) | ||
| .then(res => console.log(res)) |
There was a problem hiding this comment.
why are you chaining a .then if you do not intend to use the response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRO-198
My PR Fixes Fixes FRO-198 - Allows an admin User to update their Username in the backend.
Linear Ticket link:- https://linear.app/team-brainbox/issue/FRO-198/zuri-chat-changeset-username
Changes proposed
What were you told to do?
UPDATE AND SET USERNAME FOR ADMIN SETTINGS
What did you do?
Check List (Check all the applicable boxes)
🚨Please review the style guide for contributing and guidelines for contributing to this repository.
Screenshots/ Videos