Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MultiCombo fields UI to accept a choice of values #496

Open
jolesh opened this issue Nov 21, 2022 · 4 comments
Open

Rework MultiCombo fields UI to accept a choice of values #496

jolesh opened this issue Nov 21, 2022 · 4 comments
Labels
editor Editor pane, presets and fields
Milestone

Comments

@jolesh
Copy link
Contributor

jolesh commented Nov 21, 2022

Diet tagging has three possible values: yes, no, only

Maybe make a small table with the diet forms on the left and the values selectable, like this:
Diets:
| vegetarian | no | yes | only |
| vegan | no | yes | only |
| halal | no | yes | only |
...

Maybe accessible through a menu, just like opening hours opens a dialog.

@Robot8A
Copy link
Contributor

Robot8A commented Jul 22, 2023

I support this. Checking the code, it should require either adding a new ComboType, or changing the current ComboType.multi behaviour.

@Zverik
Copy link
Owner

Zverik commented Jul 23, 2023

Hmm. It looks like I did the multiCombo fields wrong, not even supporting "no" values. The iD editor does it right though.

One question: can multiple diet options have the only value?

@Robot8A
Copy link
Contributor

Robot8A commented Jul 23, 2023

Yes, one restaurant could be both for example only gluten-free and only vegetarian.

@Zverik Zverik added the editor Editor pane, presets and fields label Sep 28, 2023
@Zverik Zverik added this to the 3.2 milestone Sep 28, 2023
@Zverik Zverik changed the title Improve diet tagging Rework MultiCombo fields UI to accept a choice of values Sep 30, 2023
@Zverik Zverik modified the milestones: 4.0, 4.1 Sep 30, 2023
@patepelo
Copy link

patepelo commented Nov 6, 2023

It would be similar to "Take away only" field.

Maybe we can take the code from there and reuse it?

@Zverik Zverik modified the milestones: 4.2, 5.1 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Editor pane, presets and fields
Projects
Status: Todo
Development

No branches or pull requests

4 participants